-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: PDFs uploaded by "PDF transcript" feature were returnig 403 when attempting to download #32329
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 7cc53ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32329 +/- ##
===========================================
- Coverage 56.53% 56.49% -0.04%
===========================================
Files 2484 2480 -4
Lines 54694 54644 -50
Branches 11286 11279 -7
===========================================
- Hits 30921 30873 -48
Misses 21094 21094
+ Partials 2679 2677 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
https://rocketchat.atlassian.net/browse/CORE-399
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
Added a new setting
Restrict files access to users who can access room
that controls file visibility. This new setting allows users that "can access a room" to also download the files that are there. This is specially important for users with livechat manager or monitor roles, or agents that have special permissions to view closed rooms, since this allows them to download files on the conversation even after the conversation is closed.New setting is disabled by default and it is mutually exclusive with the setting
Restrict file access to room members
since this allows more types of users to download files.